Task #87746

remove assertAttribute* calls from core tests

Added by Anja Leichsenring 5 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Should have
Category:
Tests
Target version:
-
Start date:
2019-02-19
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

phpunit has deprecated and will remove all assertAttribute* methods from the framework in version 9.

Read more about the process and motivation here:
https://github.com/sebastianbergmann/phpunit/issues/3338
https://github.com/sebastianbergmann/phpunit/issues/3339

The core tests contain only 38 hits to the affected methods, so the replacement should be relatively easy. With this done, we are ready to update to the next phpunit versions.

Associated revisions

Revision f9ea59ca (diff)
Added by Anja Leichsenring 5 months ago

[TASK] Replace calls to assertAttribute* methods of phpunit

Those methods are about to be removed, in preparation the core tests
were reviewed for usage and replaced with suitable functionality.

Resolves: #87746
Releases: master
Change-Id: Ibc79e656b914f235c27d8461bcca358a38c28b6e
Reviewed-on: https://review.typo3.org/c/59758
Tested-by: Susanne Moog <>
Tested-by: TYPO3com <>
Tested-by: Daniel Goerz <>
Tested-by: Georg Ringer <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59758

#2 Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59758

#3 Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59758

#4 Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59758

#5 Updated by Gerrit Code Review 5 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59758

#6 Updated by Anonymous 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF