Project

General

Profile

Actions

Bug #87793

closed

Default submit in locked install tool reloads the form

Added by Stephan Großberndt over 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2019-02-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In Firefox (at least on Ubuntu) when entering a password in the locked install tool and pressing enter the password is not sent to the server, instead the form is just reloaded. This is due to a check on keyCode in the javascript:

$(document).on('keydown', '#t3-install-form-password', function(e) {
  if (e.keyCode === 13) {
     e.preventDefault();
     $('.t3js-login-login').click();
   }

https://github.com/TYPO3/TYPO3.CMS/blob/f9ea59ca7275b4dbfa8b118fc3e5e44c65b90547/typo3/sysext/install/Resources/Public/JavaScript/Modules/Router.js#L44-L49

Instead of keydown keypress should be used and additionally e.which should be checked.

var code = e.keyCode || e.which;
 if(code == 13) { //Enter keycode
   //Do something
 }
Actions #1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63833

Actions #2

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63833

Actions #3

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63833

Actions #4

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63849

Actions #5

Updated by Georg Ringer over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF