Bug #87838

ClassSchema must analyze all property doc blocks

Added by Alexander Schnitzler 6 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Category:
Extbase
Start date:
2019-01-17
Due date:
2019-01-17
% Done:

100%

TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

While introducing symfony/property-info with https://github.com/TYPO3/TYPO3.CMS/commit/bcde6c0177aba345b0bd363c4519892a132ef279, the analyzing of property doc blocks changed. Before, all properties had been analyzed but with that commit, the analyzing had been reduced to inject properties and collection properties. This however breaks the validation which is based on knowing the type of properties.


Related issues

Follows TYPO3 Core - Feature #87457: Use symfony/property-info to gather doc block information Closed 2019-01-16

Associated revisions

Revision e4045a28 (diff)
Added by Alexander Schnitzler 5 months ago

[BUGFIX] ClassSchema must analyze all property doc blocks

While introducing symfony/property-info with
https://review.typo3.org/c/Packages/TYPO3.CMS/+/59454,
the analyzing of property doc blocks changed. Before,
all properties had been analyzed but with that commit,
the analyzing had been reduced to inject and collection
properties. This however breaks the validation which is
based on knowing the type of properties.

Releases: master
Resolves: #87838
Relates: #87457
Change-Id: I171cbbe1bf1cc6d6bac235bd6158c2864c7deb4a
Reviewed-on: https://review.typo3.org/c/59846
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Alexander Schnitzler 6 months ago

  • Due date set to 2019-01-17
  • Start date changed from 2019-03-04 to 2019-01-17
  • Follows Feature #87457: Use symfony/property-info to gather doc block information added

#2 Updated by Gerrit Code Review 6 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59846

#3 Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59846

#4 Updated by Gerrit Code Review 6 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59846

#5 Updated by Anonymous 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF