Bug #88003
closed
Changes from draft are saved to live when switching workspaces
0%
Description
Hi,
I don't know if this behavior is wanted or rather a bug. I think it is a bug.
When you
1) make changes, e.g. changing page title, in a draft workspace
2) save the change
3) and then switch directly afterwards to live workspace
=> The result is that the changes are also being saved in the live version of the page when the page reloads.
I think this is because the iframe in which the page title has been changed is being reloaded with the save action. But I couldn't find the right way to prove this theory.
I noticed this issue in Typo3 v8.7.24 and 9.5.5. So I went to look for this issue in the forge but couldn't find any results. That's why I am asking here if this behavior is, probably, wanted?
Files
Updated by Riccardo De Contardi over 5 years ago
this behavior cannot be IMHO intended; it is also present on 10.0.0-dev (latest master)
Updated by Riccardo De Contardi over 5 years ago
If you follow instead these steps, the issue is not present
- create a page in live WS
- go to draft WS
- edit it clicking on the title (in page module), changing it and clicking on save icon
- go again in live WS
Updated by NGUYEN Duc Quan about 5 years ago
Riccardo De Contardi wrote:
If you follow instead these steps, the issue is not present
- create a page in live WS
- go to draft WS
- edit it clicking on the title (in page module), changing it and clicking on save icon
- go again in live WS
Thank you for confirming and testing.
You are right, if done the other way around like you described then it works as it should. But still the initial described scenario is a common workflow.
Does your test confirms that the issue is because of a workspace hook?
Updated by Riccardo De Contardi almost 5 years ago
The issue is still present on 10.0.0-dev (latest master); to experience it you can follow these steps:
- create a page in live WS
- go to draft WS
- edit it, for example clicking on the pencil icon
Note that it is fundamental that the editing page form opens; you can also use the context menu in pagetree
- save it
- switch to live workspace
Results:¶
the pagetree reloads and the title changed in draft workspace is adopted even in live workspace!
Additional notes¶
- as I reported on my previous comment, if you edit the page title in a way that does not open the editing page form, the issue does not happen
- It is strange that the issue affects only newly created pages if you edit again the title (in draft workspace again) it does not happen as far as I can see
- when you switch to LIVE workspace, if you don't close the editing form, the editing form of the draft workspace remains open - it should be better if it would be closed when switching workspaces.
Updated by Riccardo De Contardi about 4 years ago
- Related to Bug #89294: Workspace Switcher re-post iframe added
Updated by Riccardo De Contardi about 4 years ago
I was actually wrong: It happens also on already saved pages
Updated by Riccardo De Contardi about 4 years ago
Related issue #89294 contained an approach that has been abandoned - look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61849
Updated by Christian Kuhn almost 4 years ago
- Is duplicate of Bug #84979: Content duplication on switching from live to workspace added
Updated by Christian Kuhn almost 4 years ago
- Status changed from New to Closed
Closing as dupe of #84979 - let us follow up over there.