Bug #88010

DB Check - Full search query exception on operator change

Added by Henrik Elsner 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2019-03-26
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

DB Check Module - Full search functionality for advanced queries on e.g. page content
When "making a query" for e.g. CTypes and i'm changing the operator from "is in List" to "equals" i'm getting an exception from the QueryGenerator.php
"InputValue" is an array, causing the strottime() to break. (screenshot as attachement)

Issue Update:
When changing from "is in list" to "equals" not only an exception is thrown but also the values are thrown away.
The right behavior would be to keep the first value and use it as the query property.

Bildschirmfoto 2019-03-26 um 14.41.40.png View (292 KB) Henrik Elsner, 2019-03-26 14:50

Associated revisions

Revision d0daf82c (diff)
Added by Henrik Elsner 6 months ago

[BUGFIX] DB check - search query, array handling on operator change

Exception is thrown when changing the operator from an array handling one
to a string handling. ("is in list" to "equals")
Also the selection is not set properly after changing.

Resolves: #88010
Releases: master, 9.5

Change-Id: Ibf7f607a51ac92d2c45dbfe16384f71c959e6c1f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60342
Tested-by: TYPO3com <>
Tested-by: Mona Muzaffar <>
Tested-by: Daniel Windloff
Tested-by: Anja Leichsenring <>
Reviewed-by: Mona Muzaffar <>
Reviewed-by: Anja Leichsenring <>

Revision 59c9fc52 (diff)
Added by Henrik Elsner 6 months ago

[BUGFIX] DB check - search query, array handling on operator change

Exception is thrown when changing the operator from an array handling one
to a string handling. ("is in list" to "equals")
Also the selection is not set properly after changing.

Resolves: #88010
Releases: master, 9.5
Change-Id: I5a3cdde4457ddf024d80217db1a9b07e55d90966
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60405
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Henrik Elsner 6 months ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Assignee set to Henrik Elsner

#2 Updated by Gerrit Code Review 6 months ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60342

#3 Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60342

#4 Updated by Gerrit Code Review 6 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60404

#5 Updated by Henrik Elsner 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review 6 months ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60404

#7 Updated by Gerrit Code Review 6 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60405

#8 Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60405

#9 Updated by Henrik Elsner 6 months ago

  • Status changed from Under Review to Resolved

#10 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF