Bug #88041

Indexed Search does not respect page title from PageTitle API

Added by Jonas Schwabe 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Indexed Search
Target version:
-
Start date:
2019-03-29
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I noticed that the generatePageTitle method in TypoScriptFrontendController does not set indexedDocTitle.
Therefore indexed_search indexes the page with the page title instead of e.g. a news title if available.

#86994 also mentions that but was closed because the original issue has been resolved.

Associated revisions

Revision f04f4e80 (diff)
Added by Jonas Schwabe 9 months ago

[BUGFIX] Use PageTitle API for indexed_search

The value of indexedDocTitle was not updated when a title had been
generated by the PageTitle API. This simply writes the generated
page title to indexedDocTitle so that it can be used in the
indexed hook.

Resolves: #88041
Releases: master, 9.5
Change-Id: I8ac1fd8295447aafa7e175fb09fa11f565442019
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60354
Reviewed-by: Oliver Klee <>
Reviewed-by: Richard Haeser <>
Tested-by: Oliver Klee <>
Tested-by: TYPO3com <>
Tested-by: Richard Haeser <>

Revision 7fabc1dc (diff)
Added by Jonas Schwabe 9 months ago

[BUGFIX] Use PageTitle API for indexed_search

The value of indexedDocTitle was not updated when a title had been
generated by the PageTitle API. This simply writes the generated
page title to indexedDocTitle so that it can be used in the
indexed hook.

Resolves: #88041
Releases: master, 9.5
Change-Id: I8ac1fd8295447aafa7e175fb09fa11f565442019
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60440
Tested-by: TYPO3com <>
Tested-by: Jörg Bösche <>
Tested-by: Oliver Klee <>
Tested-by: Richard Haeser <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Richard Haeser <>

History

#1 Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60354

#2 Updated by Riccardo De Contardi 10 months ago

  • Category set to Indexed Search

#3 Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60354

#4 Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60354

#5 Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60354

#6 Updated by Gerrit Code Review 9 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60354

#7 Updated by Gerrit Code Review 9 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60354

#8 Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60440

#9 Updated by Anonymous 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack 9 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF