Bug #88066
closedInstall - wrong value returned in function executeDatabaseSelectAction
100%
Description
According to the reporting by Robin Scholz on Slack, on typo3/sysext/install/Classes/Controller/InstallerController.php
the wrong "true" value is returned at the lines 572-581 (latest master) https://github.com/TYPO3/TYPO3.CMS/blob/28a25f4f39a186fdcaaea0e01f9d91aacb4881a2/typo3/sysext/install/Classes/Controller/InstallerController.php#L572-L581:
} else { return new JsonResponse([ 'sucess' => true, 'status' => [ new FlashMessage( 'You must select a database.', 'No Database selected', FlashMessage::ERROR ), ], ]); }
Also, sucess
is spelled wrong.
Thanks Robin for your findings!
Btw the issue is present also on 9.5.5, but at different lines (568-577)
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60466
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60466
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60729
Updated by Guido Schmechel over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a776d58debc276a397cfca67965ef0ab84761f8b.