Bug #88080
closedProductionExceptionHandler should relay ImmediateResponseExceptions
100%
Description
I just noticed that ProductionExceptionHandler tries to handle ImmediateResponseException by rendering an "Oops, an error occurred" string. From what I understand this is not correct, the handler should at least relay the exception so that it can be handled accordingly.
Doc comment says:
/**
* Exception that has to be handled immediately in order to have
* stop current execution and provide the current response. This
* exception is used as alternative to previous die() or exit().
*
* @internal
*/
An ImmediateResponseException is for example thrown on cHash validation errors when pageNotFoundOnCHashError is set to "true" which then leads to Oops messages being cached when a user serves to an uncached page with an unknown GET param...
This only happens when TYPO3 is running in Production mode or the ProductionExceptionHandler is used in Dev / Staging context.
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60370
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60370
Updated by Gerrit Code Review over 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60370
Updated by Gerrit Code Review over 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60370
Updated by Gerrit Code Review over 5 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60370
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61176
Updated by Jonas Schwabe over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c82de6d0b259a151c83806da7de83a78ab549a95.