Bug #88088

cli binary is stored in wrong path

Added by Helmut Hummel almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-04-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With the change in #86513, the cli binary is now automatically generated on composer install.

Unfortunately it is written to a wrong path.
Currently we distinguish 3 paths within TYPO3 in Composer mode.

  1. TYPO3_PATH_COMPOSER_ROOT This is the path the root composer.json of the project is located
  2. TYPO3_PATH_ROOT This is TYPO3 base path formerly exposed by the constant PATH_site, now accessible with Environment::getProjectPath()
  3. TYPO3_PATH_WEB This is the path to the publicly available document root, accessible with Environment::getPublicPath()

In default TYPO3 installations, even in composer mode the two latter are the same. However with the goal of at some point being able to have a directory with only public assets,
it is important to distinguish them in the code. It becomes important already now, when using helhum/typo3-secure-web, which exposes TYPO3_PATH_WEB to a different directory and
publishes all public assets to it.
TYPO3 currently writes the cli binary to the public folder then, which should be changed


Related issues

Related to TYPO3 Core - Bug #86513: typo3/sysext/core/bin/typo3 does not work in composer modeClosed2018-10-01

Actions
#1

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60371

#2

Updated by Helmut Hummel almost 2 years ago

  • Related to Bug #86513: typo3/sysext/core/bin/typo3 does not work in composer mode added
#3

Updated by Helmut Hummel almost 2 years ago

Side note:
Generating a file and storing it inside the source directory within composer install, will mark the package as dirty for composer (can be verified with composer status).
Rather than doing that, our code that shows this path (e.g. in scheduler) should present the path to the composer binary instead.

#4

Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60371

#5

Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60371

#6

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60449

#7

Updated by Helmut Hummel almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#8

Updated by Benni Mack almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF