Project

General

Profile

Actions

Task #88160

closed

Improve handling of unsharp clicks in the page tree

Added by Alexander Stehlik about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Pagetree
Target version:
-
Start date:
2019-04-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Sprint Focus:

Description

In the last couple of days I had a strange behavior in the pagetree: it would just ignore my clicks and nothing happend. This happened at least 50% of the time.

There where no errors on the JavaScript console.

After some testing I finally realized that the problem seems to be connected to the new mouse I bought. It seems to move a little when clicking.

This tiny movement is enough to enable the drag & drop behavior of the pagetree and ignore my click.

With older TYPO3 versions (tested with version 7) with the same (broken?) mouse there were no such problems. The pagetree worked just fine.

Possible solution

There is a setting in d3-drag called clickDistance.

After raising this setting a little bit the pagetree felt much smoother and responsive.

Further thoughts

I'm not sure how many people are affected by this problem. But there might be the risk that some are and they can not figure out what is going on. This can lead to frustration and a bad user experience.

With that in mind I think it is worth "fixing" the problem since I could not see any negative side effect.

Actions #1

Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488

Actions #2

Updated by Gerrit Code Review about 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488

Actions #3

Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488

Actions #4

Updated by Sven Juergens almost 5 years ago

a brilliant find! :)
This is something that happened to me from time to time and it is very annoying. But sometimes it was there and gone again.
Therefore, I am very happy to have found this bugfix here. Have already integrated the fix into our system and now wait for feedback from other users

Actions #5

Updated by Sven Juergens almost 5 years ago

have never received such a quick feedback :)
Everyone who was affected by the problem gave me an exclusively positive feedback.
I should give you a big big thank you

Actions #6

Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488

Actions #7

Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60894

Actions #8

Updated by Alexander Stehlik almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF