Task #88160

Improve handling of unsharp clicks in the page tree

Added by Alexander Stehlik 4 months ago. Updated 27 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Pagetree
Target version:
-
Start date:
2019-04-16
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Sprint Focus:

Description

In the last couple of days I had a strange behavior in the pagetree: it would just ignore my clicks and nothing happend. This happened at least 50% of the time.

There where no errors on the JavaScript console.

After some testing I finally realized that the problem seems to be connected to the new mouse I bought. It seems to move a little when clicking.

This tiny movement is enough to enable the drag & drop behavior of the pagetree and ignore my click.

With older TYPO3 versions (tested with version 7) with the same (broken?) mouse there were no such problems. The pagetree worked just fine.

Possible solution

There is a setting in d3-drag called clickDistance.

After raising this setting a little bit the pagetree felt much smoother and responsive.

Further thoughts

I'm not sure how many people are affected by this problem. But there might be the risk that some are and they can not figure out what is going on. This can lead to frustration and a bad user experience.

With that in mind I think it is worth "fixing" the problem since I could not see any negative side effect.

Associated revisions

Revision d9308aea (diff)
Added by Alexander Stehlik 2 months ago

[TASK] Improve click behavior of the pagetree

Initialize the d3-drag clickDistance setting to prevent clicks
where the mouse slightly moves from being detected as drag
attempts.

See also:
https://github.com/d3/d3-drag#drag_clickDistance

Resolves: #88160
Releases: master, 9.5
Change-Id: I646591327e1688258e5d2d6ec3ca54000219f97a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488
Reviewed-by: Daniel Goerz <>
Reviewed-by: Paweł Rogowicz <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Paweł Rogowicz <>
Tested-by: TYPO3com <>
Tested-by: Jonas Eberle <>
Tested-by: Tymoteusz Motylewski <>

Revision edf32576 (diff)
Added by Alexander Stehlik 2 months ago

[TASK] Improve click behavior of the pagetree

Initialize the d3-drag clickDistance setting to prevent clicks
where the mouse slightly moves from being detected as drag
attempts.

See also:
https://github.com/d3/d3-drag#drag_clickDistance

Resolves: #88160
Releases: master, 9.5
Change-Id: I646591327e1688258e5d2d6ec3ca54000219f97a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60894
Tested-by: TYPO3com <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Tymoteusz Motylewski <>

History

#1 Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488

#2 Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488

#3 Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488

#4 Updated by Sven Juergens 3 months ago

a brilliant find! :)
This is something that happened to me from time to time and it is very annoying. But sometimes it was there and gone again.
Therefore, I am very happy to have found this bugfix here. Have already integrated the fix into our system and now wait for feedback from other users

#5 Updated by Sven Juergens 3 months ago

have never received such a quick feedback :)
Everyone who was affected by the problem gave me an exclusively positive feedback.
I should give you a big big thank you

#6 Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488

#7 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60894

#8 Updated by Alexander Stehlik 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Benni Mack 27 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF