Project

General

Profile

Actions

Bug #88422

closed

DocHeader.html (EXT:backend) and PageZero.html (EXT:tstemplate) contain logical and syntax errors

Added by Claus Due over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-05-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The following errors have been detected:

  • typo3/sysext/tstemplate/Resources/Private/Templates/PageZero.html

Has two conditions that contain: condition="{f:count({variable})}" which is not valid; missing the argument name. Should be corrected to inline pass.

This one prevents the check for additional TS templates from working correctly.

  • sysext/backend/Resources/Private/Partials/DocHeader.html

Has a strange condition:

1. Check that menu is not empty (good)
2. Then check that menu is not empty again (bad)
3. If it isn't empty, do something with menu (good)
4. If it IS empty, do something with menu (bad)

And due to the structure of conditions, contains invalid (X)HTML tag nesting. This one prevents one of the "else" cases from ever rendering and confuses markup validators.

Actions #1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802

Actions #2

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802

Actions #3

Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802

Actions #4

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61170

Actions #5

Updated by Anonymous over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF