Bug #88422

DocHeader.html (EXT:backend) and PageZero.html (EXT:tstemplate) contain logical and syntax errors

Added by Claus Due about 2 months ago. Updated 17 days ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-05-23
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The following errors have been detected:

  • typo3/sysext/tstemplate/Resources/Private/Templates/PageZero.html

Has two conditions that contain: condition="{f:count({variable})}" which is not valid; missing the argument name. Should be corrected to inline pass.

This one prevents the check for additional TS templates from working correctly.

  • sysext/backend/Resources/Private/Partials/DocHeader.html

Has a strange condition:

1. Check that menu is not empty (good)
2. Then check that menu is not empty again (bad)
3. If it isn't empty, do something with menu (good)
4. If it IS empty, do something with menu (bad)

And due to the structure of conditions, contains invalid (X)HTML tag nesting. This one prevents one of the "else" cases from ever rendering and confuses markup validators.

Associated revisions

Revision 4378d5ce (diff)
Added by Claus Due 17 days ago

[BUGFIX] Fix syntax and logic errors in BE Fluid templates

Fixes an invalid syntax occurrence in the "PageZero.html"
template from EXT:tstemplate. And fixes a logical error
plus incorrect XML tag nesting in the partial template
"DocHeader.html" from EXT:backend.

Change-Id: Ib38fbb2d80cd8e24a2400ec7d2dbd12dee5605ec
Resolves: #88422
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802
Tested-by: TYPO3com <>
Tested-by: Jonas Eberle <>
Tested-by: Guido Schmechel <>
Tested-by: Daniel Goerz <>
Reviewed-by: Jonas Eberle <>
Reviewed-by: Guido Schmechel <>
Reviewed-by: Daniel Goerz <>

Revision 3ff5d1a9 (diff)
Added by Claus Due 15 days ago

[BUGFIX] Fix syntax and logic errors in BE Fluid templates

Fixes an invalid syntax occurrence in the "PageZero.html"
template from EXT:tstemplate. And fixes a logical error
plus incorrect XML tag nesting in the partial template
"DocHeader.html" from EXT:backend.

Change-Id: Ib38fbb2d80cd8e24a2400ec7d2dbd12dee5605ec
Resolves: #88422
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61170
Tested-by: TYPO3com <>
Tested-by: Daniel Goerz <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802

#2 Updated by Gerrit Code Review 18 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802

#3 Updated by Gerrit Code Review 18 days ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802

#4 Updated by Gerrit Code Review 17 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61170

#5 Updated by Anonymous 17 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF