Bug #88422
closedDocHeader.html (EXT:backend) and PageZero.html (EXT:tstemplate) contain logical and syntax errors
100%
Description
The following errors have been detected:
- typo3/sysext/tstemplate/Resources/Private/Templates/PageZero.html
Has two conditions that contain: condition="{f:count({variable})}" which is not valid; missing the argument name. Should be corrected to inline pass.
This one prevents the check for additional TS templates from working correctly.
- sysext/backend/Resources/Private/Partials/DocHeader.html
Has a strange condition:
1. Check that menu is not empty (good)
2. Then check that menu is not empty again (bad)
3. If it isn't empty, do something with menu (good)
4. If it IS empty, do something with menu (bad)
And due to the structure of conditions, contains invalid (X)HTML tag nesting. This one prevents one of the "else" cases from ever rendering and confuses markup validators.
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802
Updated by Gerrit Code Review over 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802
Updated by Gerrit Code Review over 5 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61170
Updated by Anonymous over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4378d5ce7c79b2ad4b70a9c5447a0822e4d98629.