Task #88428

Deprecate top.rawurlencode and friends

Added by Andreas Fernandez about 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Should have
Category:
Backend JavaScript
Target version:
-
Start date:
2019-05-24
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Back in 2009, JavaScript code was introduced that mimics PHP's rawurlencode() and str_replace().
The only difference between rawurlencode() and encodeURIComponent() is that the latter doesn't mask asterisk characters, which isn't required anyway.

str_replace() was never necessary in first place since JavaScript supports string replace out of the box.

Associated revisions

Revision d34060b3 (diff)
Added by Andreas Fernandez about 2 months ago

[TASK] Deprecate `top.rawurlencode` and `top.str_replace`

The global JavaScript functions `top.rawurlencode()` and
`top.str_replace()` were introduced in 2009 and have been marked as
deprecated now. The code is not required and some special handling used
in these functions may get achieved with native JavaScript functions.

Resolves: #88428
Releases: master
Change-Id: Ie2c2fd42da89b00e3c9a0137231b16c2cbd21396
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60805
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Frank Naegler <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Frank Naegler <>

History

#1 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60805

#2 Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60805

#3 Updated by Gerrit Code Review about 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60805

#4 Updated by Gerrit Code Review about 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60805

#5 Updated by Andreas Fernandez about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF