Bug #88484

FE/SiteResolverTest has side effects

Added by Anja Leichsenring 5 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Should have
Category:
Tests
Target version:
-
Start date:
2019-06-03
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

the random unit test suite revealed a test that changes the state of the test environment.

typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php

it sets the locale (LC_COLLATE) to en-US without resetting it to the original state. This causes following tests to fail, if they rely on anything else.

Associated revisions

Revision 26efdc64 (diff)
Added by Anja Leichsenring 5 months ago

[BUGFIX] Remove side effect of unit test

The class typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest
manipulates the locale setting of the environment without
restoring it. So following tests might get affected by this change
and are not independent anymore.

Resolves: #88484
Releases: master, 9.5
Change-Id: I02617a34bff08606866e9015111496d75bb6dcd4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60869
Tested-by: Benni Mack <>
Tested-by: Georg Ringer <>
Reviewed-by: Benni Mack <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60869

#2 Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60869

#3 Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60869

#4 Updated by Anja Leichsenring 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF