Task #88564

Drop PageTS "TSFE.constants" functionality

Added by Benni Mack 2 months ago. Updated 26 days ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
TypoScript
Start date:
2019-06-14
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Improve performance for every page request! FE and BE!

Associated revisions

Revision 19babcf8 (diff)
Added by Benni Mack 2 months ago

[!!!][TASK] Drop PageTS "TSFE.constants" functionality

When parsing TypoScript, PageTSconfig and UserTSconfig
is taking into account for evaluting if "TSFE.constants" is
set in PageTSconfig. If this is used, this acts as a default
constant.

However, this feature has various drawbacks, and has been
superseded by actually having constants globally (FE/BE) and via
Conditions available.

For frontend calls with empty pagesection caches, this improves
performance greatly, especially in pages on a deeper level (recursion).

This also reduces the footprint to have the TypoScriptParser (incl.
condition matching) being called too often.

Resolves: #88564
Releases: master
Change-Id: Icbdfa9918a9a79510a87198bf033c4de96d71107
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61034
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61034

#2 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61034

#3 Updated by Benni Mack 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 26 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF