Bug #88701

usage of deprecated methods of PHP Redis library since version 5.0.0

Added by Hannes Bochmann 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Caching
Target version:
-
Start date:
2019-07-08
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The method $this->redis->multi(...)->sRemove() in RedisBackend.php is deprecated since PHPRedis 5.0.0. Haven't checked yet if other methods are affected, too.

Associated revisions

Revision f8189917 (diff)
Added by Markus Klein 2 months ago

[TASK] Make Redis connectors compatible with PHP redis version 5

Version 5 of phpredis deprecates some methods, which have not been
aligned to the official redis commands.
This patch replaces all calls to use the correct methods.

Resolves: #88701
Releases: master, 9.5, 8.7
Change-Id: Ib8921d31a9df6631a99d70fabc8c32f81bbd0fc4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61277
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Frank Naegler <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Frank Naegler <>

Revision ea245428 (diff)
Added by Markus Klein 2 months ago

[TASK] Make Redis connectors compatible with PHP redis version 5

Version 5 of phpredis deprecates some methods, which have not been
aligned to the official redis commands.
This patch replaces all calls to use the correct methods.

Resolves: #88701
Releases: master, 9.5, 8.7
Change-Id: Ib8921d31a9df6631a99d70fabc8c32f81bbd0fc4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61457
Tested-by: TYPO3com <>
Tested-by: Frank Naegler <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Frank Naegler <>

Revision 71f40ba4 (diff)
Added by Markus Klein 2 months ago

[TASK] Make Redis connectors compatible with PHP redis version 5

Version 5 of phpredis deprecates some methods, which have not been
aligned to the official redis commands.
This patch replaces all calls to use the correct methods.

Resolves: #88701
Releases: master, 9.5, 8.7
Change-Id: Ib8921d31a9df6631a99d70fabc8c32f81bbd0fc4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61458
Tested-by: TYPO3com <>
Tested-by: Frank Naegler <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Frank Naegler <>

History

#1 Updated by Markus Klein 3 months ago

  • Status changed from New to Accepted
  • TYPO3 Version changed from 10 to 8

Yes, Redis::delete().

We should make the core compatible with both versions of the redis-extension.

https://pecl.php.net/package/redis

#2 Updated by Markus Klein 3 months ago

Regex to search for all deprecated functions according to the git changelog of phpredis

(delete|evaluate|evaluateSha|getKeys|getMultiple|lGet|lGetRange|lRemove|lSize|listTrim|open|popen|renameKey|sContains|sGetMembers|sRemove|sSize|sendEcho|setTimeout|substr|zDelete|zDeleteRangeByRank|zDeleteRangeByScore|zInter|zRemove|zRemoveRangeByScore|zReverseRange|zSize|zUnion)\(

#3 Updated by Gerrit Code Review 3 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61277

#4 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61277

#5 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61277

#6 Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61277

#7 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61457

#8 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61458

#9 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61458

#10 Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61458

#11 Updated by Markus Klein 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Gerrit Code Review 2 months ago

  • Status changed from Resolved to Under Review

Patch set 4 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61458

#13 Updated by Markus Klein 2 months ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF