Task #88721

Epic #83968: PSR-11 Initiative

Hook up ContainerInterface in backend route dispatcher

Added by Benjamin Franzke 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Start date:
2019-07-11
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Backend RouterDispatcher use the symfony provided PSR-11 container to retrieve services from the container, if available.

Associated revisions

Revision 98f415c6 (diff)
Added by Benjamin Franzke 2 months ago

[TASK] Hook up ContainerInterface in backend route dispatcher

Transform InfoModuleController and it's dependency ModuleTemplate
into a symfony manageed services to retrieve dependencies from
symfony instead of GeneralUtility::makeInstance.
ModuleTemplate is a prototype and is therefore marked shared: false.
It is marked public: true so legacy calls to
GeneralUtility::makeInstance(ModuleTemplate::class) resort to the
container and properly inject dependencies.

Also add a backend.controller symfony tag, to be universally
applied for backend controllers. This tag automatically configures
the controller to be publicly available from $container->get()
which allows the route dispatcher to lazily instantiate
the controller.

Releases: master
Resolves: #88721
Change-Id: I076c306736243e693542f2774dbe1108e28fe731
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61246
Tested-by: TYPO3com <>
Tested-by: Jörg Bösche <>
Tested-by: Steffen Frese <>
Tested-by: Benni Mack <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Steffen Frese <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61246

#2 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61246

#3 Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61246

#4 Updated by Benjamin Franzke 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF