Project

General

Profile

Actions
Copy link

Bug #88726

closed

$orderByFields is not handen over to parent::init() for PageTreeView

Added by Tomas Norre Mikkelsen over 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-07-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi.

Today I saw that the $orderByFields isn't handed over to the parent::init() for the PageTreeView.
https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/backend/Classes/Tree/View/PageTreeView.php#L70

I don't know what consequences this have, but there are currently no tests covering this.

This has been in the core for where long, without any notice, so it cannot have a big impact on the users of TYPO3.

6.2 -> https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_6-2/typo3/sysext/backend/Classes/Tree/View/PageTreeView.php#L57
6.1 -> https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_6-1/typo3/sysext/backend/Classes/Tree/View/PageTreeView.php#L69
6.0 -> https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_6-0/typo3/sysext/backend/Classes/Tree/View/PageTreeView.php#L78

I'll be happy to help fixing this. But would like to have your confirmation first that it's issue.

Thanks in advance.
Tomas

Actions
Copy link
 #1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63931

Actions
Copy link
 #2

Updated by Susanne Moog over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF