Task #88787

Deprecate BackendUtility::editOnClick

Added by Daniel Windloff 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Should have
Category:
Code Cleanup
Target version:
-
Start date:
2019-07-17
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Deprecate BackendUtility::editOnClick.
Replace remaining usages of editOnClick with links where it is possible.


Related issues

Related to TYPO3 Core - Bug #88864: Wrong usage of makeReturnUrl() Resolved 2019-07-30

Associated revisions

Revision 57dea057 (diff)
Added by Andreas Fernandez 3 months ago

[TASK] Deprecate BackendUtility::editOnClick()

This patch deprecates BackendUtility::editOnClick() which is used to build
a JavaScript-based redirect to the EditDocumentController for use in an
`onclick` attribute. This approach is not necessary anymore, thus all
links use a real `href` attriute now.

Also, this patch removes the following methods:
- TYPO3\CMS\Backend\View\PageLayoutView::linkWrapTable()
- TYPO3\CMS\Backend\View\PageLayoutView::linkWrapItems()
- TYPO3\CMS\Backend\View\PageLayoutView::newContentElementOnClick()

Reason is that these methods contain code that would need a migration, but
are unused in the whole Core. Since the class is marked as "internal",
it's considered safe to remove them.

Resolves: #88787
Releases: master
Change-Id: I8bd3868287204fc3275a43f938d9aeb9fbb6306d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61377
Tested-by: TYPO3com <>
Tested-by: Daniel Windloff
Tested-by: Georg Ringer <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Daniel Windloff
Reviewed-by: Georg Ringer <>
Reviewed-by: Andreas Fernandez <>

Revision d2960656 (diff)
Added by Andreas Fernandez 3 months ago

[BUGFIX] Use correct matcher for `BackendUtility::editOnClick`

Resolves: #88855
Related: #88787
Releases: master
Change-Id: I3578c36fac2a6bb57704d41ccfa60a6dbd4727b9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61386
Tested-by: Anja Leichsenring <>
Reviewed-by: Anja Leichsenring <>

Revision 595a5a84 (diff)
Added by Andreas Fernandez 3 months ago

[BUGFIX] Drop superfluous `returnUrl` argument

With #88787 the method `makeReturnUrl()` is used to append the returnUrl
to the links. The method already attaches the `returnUrl` argument, this
patch removes the superfluous arguments.

Resolves: #88864
Related: #88787
Releases: master
Change-Id: I95103a11215e5ec1157a7a239130fdd95996f14a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61391
Tested-by: Frank Naegler <>
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Frank Naegler <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61377

#2 Updated by Andreas Fernandez 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Andreas Fernandez 3 months ago

  • Related to Bug #88864: Wrong usage of makeReturnUrl() added

Also available in: Atom PDF