Bug #88794

Call to undefined method TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::checkPassword() on report module

Added by Philippe COURT 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Must have
Category:
Reports
Start date:
2019-07-18
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Error {#2795 ▼
#message: "Call to undefined method TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::checkPassword()"
#code: 0
#file: "/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/install/Classes/Report/SecurityStatusReport.php"
#line: 65
trace: {▼
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/install/Classes/Report/SecurityStatusReport.php:65 {▼
› if ($installToolPassword !== '' && $hashInstance === null) {
› $validPassword = !$hashFactory->checkPassword('joh316', $installToolPassword);
› } elseif ($installToolPassword === md5('joh316')) {
}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/install/Classes/Report/SecurityStatusReport.php:39 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/reports/Classes/Report/Status/Status.php:95 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/reports/Classes/Report/Status/Status.php:55 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/reports/Classes/Controller/ReportController.php:163 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/reports/Classes/Controller/ReportController.php:109 {▶}
TYPO3\CMS\Reports\Controller\ReportController->handleRequest() {}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Http/RouteDispatcher.php:87 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Http/RequestHandler.php:73 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Middleware/SiteResolver.php:59 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:138 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Middleware/AdditionalResponseHeaders.php:39 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:138 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Middleware/OutputCompression.php:45 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:138 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Middleware/LegacyBackendTemplateInitialization.php:42 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:138 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php:70 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:138 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Middleware/BackendRouteInitialization.php:72 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:138 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Middleware/ForcedHttpsBackendRedirector.php:53 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:138 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Middleware/LockedBackendGuard.php:71 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:138 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Middleware/NormalizedParamsAttribute.php:58 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:138 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:67 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/AbstractApplication.php:98 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/backend/Classes/Http/Application.php:68 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/sysext/core/Classes/Http/AbstractApplication.php:110 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/index.php:24 {▶}
/home/DE/pcourt/dev.sunshine.qua/web/typo3/index.php:25 {▶}

The correct code would be `$hashFactory->get($installToolPassword, 'BE')->checkPassword('joh316', $installToolPassword)` ????

Associated revisions

Revision fdd8d972 (diff)
Added by Mathias Brodala 5 months ago

[BUGFIX] Properly check install tool password in report

Also output a report message in case of unsupported hash algorithm.

Resolves: #88794
Releases: master, 9.5
Change-Id: I1ba4efd321f4d2d5bc35b65bb7caac0581fe0a39
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61318
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Benjamin Franzke <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Benjamin Franzke <>

Revision e83bb5f3 (diff)
Added by Mathias Brodala 5 months ago

[BUGFIX] Properly check install tool password in report

Also output a report message in case of unsupported hash algorithm.

Resolves: #88794
Releases: master, 9.5
Change-Id: I1ba4efd321f4d2d5bc35b65bb7caac0581fe0a39
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61332
Tested-by: TYPO3com <>
Tested-by: Benjamin Franzke <>
Reviewed-by: Benjamin Franzke <>

History

#1 Updated by Mathias Brodala 5 months ago

  • Assignee set to Mathias Brodala
  • Priority changed from Should have to Must have
  • TYPO3 Version changed from 9 to 10

#2 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61318

#3 Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61318

#4 Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61318

#5 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61332

#6 Updated by Mathias Brodala 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF