Bug #88963
closedRedirectService is not taking additional parameters
100%
Description
When using additinal parameters in typolink as link target these parameters are not appended in redirect.
E.g. my link target as typolink is:
t3://page?uid=2 - - - q=support
When I add this as link target in redirect entry, I can see the correct link generated in Redirects backend module in column "destination".
But klicking the preview or entering the source_url, the additional parameter "q=support" is not used.
I found the problem in \TYPO3\CMS\Redirects\Service\RedirectService::getTargetUrl().
Because the source_path itself has no query parameters, they are not commited when this method is called at:
TYPO3\CMS\Redirects\Http\Middleware\RedirectHandler::process()
#60 $url = $redirectService->getTargetUrl($matchedRedirect, $request->getQueryParams(), $request->getAttribute('site', null));
I found a solution for fixing this problem by adding additional parameters from target typolink which I add.
Greetings,
Manfred MIrsch
Files
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61509
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61509
Updated by Guido Schmechel over 5 years ago
Hi Manfred,
thanks for your findings. I add your patch with a test to the review system. Feel free to optimize.
Updated by Gerrit Code Review about 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61509
Updated by Gerrit Code Review about 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61509
Updated by Gerrit Code Review about 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62055
Updated by Guido Schmechel about 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 607f935460502765093c2ad0ae4b6ec9beb8ae7f.
Updated by Gerrit Code Review about 5 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62055
Updated by Gerrit Code Review about 5 years ago
Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62055
Updated by Guido Schmechel about 5 years ago
- Status changed from Under Review to Resolved
Applied in changeset 7a27797916bb0f2baec050cefb333d224c000d17.