Project

General

Profile

Actions

Bug #89149

closed

Fix assertion ordering in test cases

Added by Oliver Hader over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Tests
Target version:
-
Start date:
2019-09-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

1) TYPO3\CMS\Backend\Tests\Functional\Clipboard\ClipboardTest::localizationsAreResolved with data set "live workspace with live & version localizations" (1100, 0, array('FR: Welcome', 'FR-CA: Welcome'))
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
-    0 => 'FR: Welcome'
-    1 => 'FR-CA: Welcome'
+    0 => 'FR-CA: Welcome'
+    1 => 'FR: Welcome'
 )

Use assertEqualsCanonicalizing instead of assertSame on array values to ignore ordering.


Related issues 1 (0 open1 closed)

Follows TYPO3 Core - Bug #89138: Correctly retrieve workspace versionsClosed2019-09-10

Actions
Actions #1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61666

Actions #2

Updated by Oliver Hader over 4 years ago

  • Follows Bug #89138: Correctly retrieve workspace versions added
Actions #3

Updated by Oliver Hader over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF