Task #89221

Remove obsolet part from _GET and _POST PHPDocs

Added by Oliver Bartsch about 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Should have
Category:
Code Cleanup
Target version:
-
Start date:
2019-09-22
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

The PHPDoc of the wrapper methods _GET and _POST in GeneralUtility claim that slashes would be stripped out but this isn't the case (anymore).
Also the sentence contains a typo `stipped` should be `stripped`.

Therefore this part should be removed from the PHPDocs at all.

Associated revisions

Revision c9c8d601 (diff)
Added by Oliver Bartsch about 2 months ago

[TASK] Remove obsolet PHPDoc parts

The PHPDocs of GeneralUtility::_GET and GeneralUtility::_POST
have been revised. In detail, statements have been removed
that those methods would strip slashes and should `ALWAYS` be used.

Resolves: #89221
Releases: master, 9.5
Change-Id: Ic05f31998b8af5205cd6847c403b95172eeb709a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61773
Tested-by: TYPO3com <>
Tested-by: Björn Jacob <>
Tested-by: Daniel Goerz <>
Reviewed-by: Björn Jacob <>
Reviewed-by: Daniel Goerz <>

Revision c21d6d70 (diff)
Added by Oliver Bartsch about 2 months ago

[TASK] Remove obsolet PHPDoc parts

The PHPDocs of GeneralUtility::_GET and GeneralUtility::_POST
have been revised. In detail, statements have been removed
that those methods would strip slashes and should `ALWAYS` be used.

Resolves: #89221
Releases: master, 9.5
Change-Id: Ic05f31998b8af5205cd6847c403b95172eeb709a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61785
Tested-by: TYPO3com <>
Tested-by: Daniel Goerz <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61773

#2 Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61773

#3 Updated by Gerrit Code Review about 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61773

#4 Updated by Gerrit Code Review about 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61773

#5 Updated by Oliver Bartsch about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review about 2 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61785

#7 Updated by Oliver Bartsch about 2 months ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF