Task #89222

Improve PHPDoc of GeneralUtility::_GP

Added by Oliver Bartsch 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Should have
Category:
Code Cleanup
Target version:
-
Start date:
2019-09-22
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The PHPDoc of the method `_GP` from GeneralUtility should be improved as the description seems to be outdated and a bit misleading concerning "security".

Associated revisions

Revision f5caac1d (diff)
Added by Oliver Bartsch about 2 months ago

[TASK] Improve PHPDoc of GeneralUtility::_GP

The PHPDoc of GeneralUtility::_GP has been revised.
In detail, the outdated and misleading part about security
has been removed and the return annotation now also
includes NULL as possible return type.

Resolves: #89222
Releases: master, 9.5
Change-Id: Iccfbfc43b15b28c035f5e93805d41e858b816d6a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61774
Tested-by: TYPO3com <>
Tested-by: Björn Jacob <>
Tested-by: Daniel Goerz <>
Reviewed-by: Björn Jacob <>
Reviewed-by: Daniel Goerz <>

Revision 4229c895 (diff)
Added by Oliver Bartsch about 2 months ago

[TASK] Improve PHPDoc of GeneralUtility::_GP

The PHPDoc of GeneralUtility::_GP has been revised.
In detail, the outdated and misleading part about security
has been removed and the return annotation now also
includes NULL as possible return type.

Resolves: #89222
Releases: master, 9.5
Change-Id: Iccfbfc43b15b28c035f5e93805d41e858b816d6a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61743
Tested-by: TYPO3com <>
Tested-by: Daniel Goerz <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61774

#2 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61774

#3 Updated by Oliver Bartsch 2 months ago

  • Status changed from Under Review to New
  • Assignee set to Oliver Bartsch

#4 Updated by Oliver Bartsch 2 months ago

  • Status changed from New to Under Review

#5 Updated by Gerrit Code Review about 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61743

#6 Updated by Oliver Bartsch about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF