Task #89257

TypoScriptTemplateModuleController handles unused clear_all_cache paramter

Added by Benjamin Franzke about 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Should have
Category:
Code Cleanup
Start date:
2019-09-25
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The following code in typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php is unused:

// Clear the cache if requested
if (($request->getParsedBody()['clear_all_cache'] ?? $request->getQueryParams()['clear_all_cache'] ?? false)) {
    $tce = GeneralUtility::makeInstance(DataHandler::class);
    $tce->start([], []);
    $tce->clear_cacheCmd('all');
}

The frontend part that issued the GET parameter clear_all_cache=1 was
removed in 2008 with the following commit:
https://github.com/TYPO3/TYPO3.CMS/commit/94fb08233d

The handling of this unused parameter should therefore be removed.

Associated revisions

Revision ebaf66d4 (diff)
Added by Benjamin Franzke about 2 months ago

[TASK] Remove left-over clear_all_cache code from TS module controller

The frontend part that issued the GET parameter clear_all_cache=1 was
removed in 2008 with the following commit:
https://github.com/TYPO3/TYPO3.CMS/commit/94fb08233d

The handling of this unused parameter is therefore removed.

Releases: master
Resolves: #89257
Change-Id: I4d248d388fb8efdb11df9eb7fd6d976338fa65d1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61804
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61804

#2 Updated by Benjamin Franzke about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF