Task #89282

CGL violation in FileList

Added by Benjamin Franzke about 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Start date:
2019-09-26
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

https://review.typo3.org/c/Packages/TYPO3.CMS/+/57414 introduced a CGL violation
because https://review.typo3.org/c/Packages/TYPO3.CMS/+/57414 has been merged between push/testrun and merge of the mentioned patch.

Associated revisions

Revision 9bc0fea3 (diff)
Added by Benjamin Franzke about 2 months ago

[TASK] Fix CGL violation in FileList

https://review.typo3.org/c/Packages/TYPO3.CMS/+/57414 introduced
a CGL violation that was not discovered because the patchset was
pushed on 8th of august and was checked with php-cs-fixer 2.14.1
on bamboo where no violation was found.

In the meantime (between push and merge of the mentioned patch)
https://review.typo3.org/c/Packages/TYPO3.CMS/+/61564 has been
merged, which updates php-cs-fixer to 2.15.2 and contains new
rules.

Releases: master
Resolves: #89282
Related: #57414
Related: #85425
Change-Id: I61d5e6e5dc61b500fe620e59002f296f50f03214
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61835
Tested-by: TYPO3com <>
Tested-by: Björn Jacob <>
Tested-by: Oliver Bartsch <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Björn Jacob <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61835

#2 Updated by Benjamin Franzke about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF