Bug #89376

Linkvalidator report does not show additional exception messages reported by Guzzle

Added by Sybille Peters 8 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2019-10-08
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The error message that is displayed, is based on the error type. However, Guzzle reports additional information which might help to determine why some broken links are reported (specifically to interpret false negatives).

  • e.g. problem with ssl certificate, error type is "network", the message displayed is "Network error / invalid domain". Guzzle throws \GuzzleHttp\Exception\RequestException and there is additional information in the exception message: "cURL error 60: SSL: certificate subject name 'xubuntu' does not match target host name 't3coredev' (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)"

Associated revisions

Revision 05eaac74 (diff)
Added by Sybille Peters 8 months ago

[BUGFIX] Show exception in linkvalidator report

For \GuzzleHttp\Exception\RequestException the exception message
is now shown as well (as for the other exceptions). This makes
it easier to interpret the error messages as this exception may
be thrown for a number of reasons, such as not existing domain,
problem with SSL certificate etc.

Resolves: #89376
Releases: master, 9.5
Change-Id: If5cd24e35afdbdede37379fab4055eff84933f48
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61909
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Jörg Bösche <>
Tested-by: Julian Geils <>
Tested-by: Sascha Rademacher <>
Tested-by: Steffen Frese <>
Tested-by: Henning Liebe <>
Tested-by: Susanne Moog <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Julian Geils <>
Reviewed-by: Sascha Rademacher <>
Reviewed-by: Felix P. <>
Reviewed-by: Steffen Frese <>
Reviewed-by: Henning Liebe <>
Reviewed-by: Susanne Moog <>

Revision 9573a903 (diff)
Added by Sybille Peters 8 months ago

[BUGFIX] Show exception in linkvalidator report

For \GuzzleHttp\Exception\RequestException the exception message
is now shown as well (as for the other exceptions). This makes
it easier to interpret the error messages as this exception may
be thrown for a number of reasons, such as not existing domain,
problem with SSL certificate etc.

Resolves: #89376
Releases: master, 9.5
Change-Id: If5cd24e35afdbdede37379fab4055eff84933f48
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61924
Tested-by: TYPO3com <>
Tested-by: Sascha Rademacher <>
Tested-by: Georg Ringer <>
Reviewed-by: Sascha Rademacher <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61909

#2 Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61924

#3 Updated by Sybille Peters 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF