Bug #89402

HMENU with special=directoy removes mount point if target page is in same menu

Added by Alexander Stehlik 5 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
-
Start date:
2019-10-11
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
7.2
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

This is a bit of an edge case but it caused me some head scratching:

I added a menu of subpages to a pagetree that looks like this:

  • page 1 (default)
  • page 2 (MP to page 1)

The menu will only render one of the two pages.

The reason is simple: the page UID is used as array key in the menu item array.

\TYPO3\CMS\Frontend\ContentObject\Menu\AbstractMenuContentObject::prepareMenuItemsForDirectoryMenu():

$menuItems[$row['uid']] = $this->sys_page->getPageOverlay($row);

Associated revisions

Revision 819db04f (diff)
Added by Alexander Stehlik 4 months ago

[BUGFIX] Use indexed menu item array for directory menu

This prevents overwriting existing entries when a mount point
and its target have the same parent.

Resolves: #89402
Releases: master, 9.5
Change-Id: I1e527443410e0f875a95e803d4c3c026b089f5a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61962
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Susanne Moog <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Guido Schmechel <>
Reviewed-by: Susanne Moog <>

Revision 83f29c25 (diff)
Added by Alexander Stehlik about 1 month ago

[BUGFIX] Use indexed menu item array for directory menu

This prevents overwriting existing entries when a mount point
and its target have the same parent.

Resolves: #89402
Releases: master, 9.5
Change-Id: I1e527443410e0f875a95e803d4c3c026b089f5a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62225
Tested-by: TYPO3com <>
Tested-by: Alexander Stehlik <>
Tested-by: Markus Klein <>
Tested-by: Tobi Kretschmann <>
Reviewed-by: Alexander Stehlik <>
Reviewed-by: Markus Klein <>
Reviewed-by: Tobi Kretschmann <>

History

#1 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61962

#2 Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61962

#3 Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61962

#4 Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61962

#5 Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61962

#6 Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62225

#7 Updated by Alexander Stehlik 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF