Task #89407

Fix get_dirs return type annotation

Added by Daniel Siepmann about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Category:
-
Start date:
2019-10-14
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

Right now the method can return either an array, null or an string, but only array is defined within PHPDoc.

This prevents static code analysis for further code using this method, e.g. inside extensions.


Related issues

Related to TYPO3 Core - Task #89409: Fix Extbase getArgument return type annotation Resolved 2019-10-14

Associated revisions

Revision fefeddda (diff)
Added by Daniel Siepmann about 1 month ago

[TASK] Fix return type annotation of get_dirs method

As three different return types can be returned, they should all be
documented. This allows for better autocompletion and type safety through
static code analysis.

Resolves: #89407
Releases: master, 9.5, 8.7
Change-Id: I181bc9b79eeaa4add0d2d06cfd6b8b2fda330442
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61967
Reviewed-by: Oliver Klee <>
Reviewed-by: Daniel Siepmann <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Tobi Kretschmann <>
Reviewed-by: Frank Nägler <>
Tested-by: Daniel Siepmann <>
Tested-by: Oliver Bartsch <>
Tested-by: TYPO3com <>
Tested-by: Frank Nägler <>

Revision 7ef63018 (diff)
Added by Daniel Siepmann about 1 month ago

[TASK] Fix return type annotation of get_dirs method

As three different return types can be returned, they should all be
documented. This allows for better autocompletion and type safety through
static code analysis.

Resolves: #89407
Releases: master, 9.5, 8.7
Change-Id: I181bc9b79eeaa4add0d2d06cfd6b8b2fda330442
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61984
Tested-by: TYPO3com <>
Tested-by: Frank Nägler <>
Reviewed-by: Frank Nägler <>

Revision 495b136b (diff)
Added by Daniel Siepmann about 1 month ago

[TASK] Fix return type annotation of get_dirs method

As three different return types can be returned, they should all be
documented. This allows for better autocompletion and type safety through
static code analysis.

Resolves: #89407
Releases: master, 9.5, 8.7
Change-Id: I181bc9b79eeaa4add0d2d06cfd6b8b2fda330442
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61985
Tested-by: TYPO3com <>
Tested-by: Frank Nägler <>
Reviewed-by: Frank Nägler <>

History

#1 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61967

#2 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61967

#3 Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61967

#4 Updated by Daniel Siepmann about 1 month ago

  • Related to Task #89409: Fix Extbase getArgument return type annotation added

#5 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61984

#6 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61985

#7 Updated by Daniel Siepmann about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF