Task #89409

Fix Extbase getArgument return type annotation

Added by Daniel Siepmann about 1 month ago. Updated 29 days ago.

Status:
Resolved
Priority:
Should have
Category:
-
Start date:
2019-10-14
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Sprint Focus:

Description

Right now the method can return whatever an argument is, but only string is defined within PHPDoc. E.g. arguments can be an array instead.

This prevents static code analysis for further code using this method, e.g. inside extensions.


Related issues

Related to TYPO3 Core - Task #89407: Fix get_dirs return type annotation Resolved 2019-10-14
Related to TYPO3 Core - Bug #89432: Fix Extbase redirect param type annotation Resolved 2019-10-16

Associated revisions

Revision 17404c45 (diff)
Added by Daniel Siepmann 29 days ago

[TASK] Fix return type annotation of Extbase getArgument method

It is possible to have an array as argument, e.g. select, checkbox, …
Therefore also arrays can be returned by this method.

Resolves: #89409
Releases: master, 9.5, 8.7
Change-Id: I8b6dc27d5c326e41bc2be3fcaac0770a5e953a87
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61969
Reviewed-by: Oliver Klee <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Sybille Peters <>
Reviewed-by: Alexander Schnitzler <>
Tested-by: TYPO3com <>
Tested-by: Daniel Goerz <>
Tested-by: Alexander Schnitzler <>

Revision b5acd62e (diff)
Added by Daniel Siepmann 29 days ago

[TASK] Fix return type annotation of Extbase getArgument method

It is possible to have an array as argument, e.g. select, checkbox, …
Therefore also arrays can be returned by this method.

Resolves: #89409
Releases: master, 9.5, 8.7
Change-Id: I8b6dc27d5c326e41bc2be3fcaac0770a5e953a87
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62053
Tested-by: TYPO3com <>
Tested-by: Alexander Schnitzler <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Alexander Schnitzler <>

Revision 90ed984c (diff)
Added by Daniel Siepmann 29 days ago

[TASK] Fix return type annotation of Extbase getArgument method

It is possible to have an array as argument, e.g. select, checkbox, …
Therefore also arrays can be returned by this method.

Resolves: #89409
Releases: master, 9.5, 8.7
Change-Id: I8b6dc27d5c326e41bc2be3fcaac0770a5e953a87
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62054
Tested-by: TYPO3com <>
Tested-by: Alexander Schnitzler <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Alexander Schnitzler <>

History

#1 Updated by Daniel Siepmann about 1 month ago

  • Related to Task #89407: Fix get_dirs return type annotation added

#2 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61969

#3 Updated by Daniel Siepmann about 1 month ago

  • Related to Bug #89432: Fix Extbase redirect param type annotation added

#4 Updated by Gerrit Code Review 29 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62053

#5 Updated by Gerrit Code Review 29 days ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62054

#6 Updated by Daniel Siepmann 29 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF