Bug #89431
closedRequire JS config packages gets overruled
100%
Description
Trying to add a 'highcharts' module to require js, i use the method 'addRequireJsConfiguration' of the 'PageRender' class.
Since the packages array is numerically indexed all existing entries at the same position get overridden by my definition. Or the other way around: an extension loaded after mine will override my packages if it adds packages itself.
here is my configuration:
$pageRenderer = GeneralUtility::makeInstance(PageRenderer::class);
$pageRenderer->addRequireJsConfiguration([
'packages' => [[
'name' => 'highcharts',
'main' => 'highcharts'
]],
'paths' => [
'highcharts' => 'https://code.highcharts.com'
],
]);
Updated by Susanne Moog over 4 years ago
- Category changed from Backend API to Backend JavaScript
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63816
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63782
Updated by Andreas Fernandez over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 19964c95bfaee15b5ddd31dcf93a6c5cd5c77bcd.
Updated by Gerrit Code Review over 4 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63782
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63782
Updated by Andreas Fernandez over 4 years ago
- Status changed from Under Review to Resolved
Applied in changeset 81c88870982c0a24851a2c2f13d26fbe7e270f47.