Project

General

Profile

Actions

Bug #89431

closed

Require JS config packages gets overruled

Added by Kay Wienöbst about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
-
Start date:
2019-10-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Trying to add a 'highcharts' module to require js, i use the method 'addRequireJsConfiguration' of the 'PageRender' class.

Since the packages array is numerically indexed all existing entries at the same position get overridden by my definition. Or the other way around: an extension loaded after mine will override my packages if it adds packages itself.

here is my configuration:


$pageRenderer = GeneralUtility::makeInstance(PageRenderer::class);
$pageRenderer->addRequireJsConfiguration([
'packages' => [[
'name' => 'highcharts',
'main' => 'highcharts'
]],
'paths' => [
'highcharts' => 'https://code.highcharts.com'
],
]);

Actions #1

Updated by Susanne Moog over 4 years ago

  • Category changed from Backend API to Backend JavaScript
Actions #2

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63816

Actions #3

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63782

Actions #4

Updated by Andreas Fernandez over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63782

Actions #6

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63782

Actions #7

Updated by Andreas Fernandez over 4 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF