Bug #89432

Fix Extbase redirect param type annotation

Added by Daniel Siepmann about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Category:
-
Start date:
2019-10-16
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Right now the method accepts strings and nulls for some arguments, but only string is defined within PHPDoc.

This prevents static code analysis for further code using this method, e.g. inside extensions.


Related issues

Related to TYPO3 Core - Task #89409: Fix Extbase getArgument return type annotation Resolved 2019-10-14

Associated revisions

Revision 80f5b0cf (diff)
Added by Daniel Siepmann about 1 month ago

[TASK] Fix param type annotation of Extbase methods

It is possible to provide null for these arguments.
The defaults are even null. Therefore this should be documented, as this
is expected to trigger a specific behaviour.

E.g. not providing an extension or controller name results to the
current one.

Resolves: #89432
Releases: master, 9.5, 8.7
Change-Id: I9d65b902be322a274db117db08473c193a057e7b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62006
Tested-by: TYPO3com <>
Tested-by: Frank Nägler <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Frank Nägler <>

Revision 15ba89e8 (diff)
Added by Daniel Siepmann about 1 month ago

[TASK] Fix param type annotation of Extbase methods

It is possible to provide null for these arguments.
The defaults are even null. Therefore this should be documented, as this
is expected to trigger a specific behaviour.

E.g. not providing an extension or controller name results to the
current one.

Resolves: #89432
Releases: master, 9.5, 8.7
Change-Id: I9d65b902be322a274db117db08473c193a057e7b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61978
Tested-by: TYPO3com <>
Tested-by: Daniel Siepmann <>
Tested-by: Frank Nägler <>
Reviewed-by: Daniel Siepmann <>
Reviewed-by: Frank Nägler <>

Revision ccfa6dac (diff)
Added by Daniel Siepmann about 1 month ago

[TASK] Fix param type annotation of Extbase methods

It is possible to provide null for these arguments.
The defaults are even null. Therefore this should be documented, as this
is expected to trigger a specific behaviour.

E.g. not providing an extension or controller name results to the
current one.

Resolves: #89432
Releases: master, 9.5, 8.7
Change-Id: I9d65b902be322a274db117db08473c193a057e7b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61979
Tested-by: TYPO3com <>
Tested-by: Daniel Siepmann <>
Tested-by: Frank Nägler <>
Reviewed-by: Daniel Siepmann <>
Reviewed-by: Frank Nägler <>

History

#1 Updated by Daniel Siepmann about 1 month ago

  • Related to Task #89409: Fix Extbase getArgument return type annotation added

#2 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62006

#3 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61978

#4 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61979

#5 Updated by Daniel Siepmann about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF