Task #89465

Make Permission class a BitSet instead of Enumeration

Added by Alexander Schnitzler about 1 year ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Should have
Category:
-
Start date:
2019-10-21
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #92208: Page Permission class is used on wrong properties Resolved 2020-09-05
Related to TYPO3 Core - Bug #92307: DatabaseRecordList: Permissions for "cut" (for records except pages) Closed 2020-09-14

Associated revisions

Revision 263ad4a5 (diff)
Added by Alexander Schnitzler about 2 months ago

[TASK] Make Permission class a BitSet instead of Enumeration

The Permission class unnecessarily had been implemented as
Enumeration although the features of the Enumeration base
class hadn't been used.

As the Permission class only handles boolean flags, it is
now implemented as bit set, which improves the performance
in comparison to Enumeration classes.

Releases: master
Resolves: #89465
Change-Id: I73eff34090a7ea8e02f7d538e2db52045c86d438
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Christian Kuhn <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Benni Mack <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>

Revision ef5d3e24 (diff)
Added by Daniel Windloff about 1 month ago

[BUGFIX] DatabaseRecordList: Set permission for "cut"

Use `editContentPermissionIsGranted()` to calculate the permission
to cut records (except pages).

Releases: master
Related: #89465
Resolves: #92307
Change-Id: I387c486c3814c3e5b6f4959d6c725ff59562c32e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65736
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Tested-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099

#2 Updated by Gerrit Code Review 12 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099

#3 Updated by Gerrit Code Review 10 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099

#4 Updated by Gerrit Code Review 10 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099

#5 Updated by Gerrit Code Review 9 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099

#6 Updated by Alexander Schnitzler 8 months ago

  • Target version set to Candidate for Major Version

#7 Updated by Gerrit Code Review 6 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099

#8 Updated by Gerrit Code Review 2 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099

#9 Updated by Gerrit Code Review about 2 months ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099

#10 Updated by Anonymous about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Benni Mack about 2 months ago

  • Related to Bug #92208: Page Permission class is used on wrong properties added

#12 Updated by Daniel Windloff about 1 month ago

  • Related to Bug #92307: DatabaseRecordList: Permissions for "cut" (for records except pages) added

Also available in: Atom PDF