Task #89477

Switch to named keys in generateMetaTags hook

Added by Richard Haeser about 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
SEO
Target version:
-
Start date:
2019-10-22
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

EXT:seo is adding scripts to the $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Frontend\Page\PageGenerator']['generateMetaTags'] hook. It is using automatic numeric keys because we use `$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Frontend\Page\PageGenerator']['generateMetaTags'][]`. We should change that to named keys so it is more easy to disable specific generators.

Associated revisions

Revision 9d7c1a3a (diff)
Added by Richard Haeser about 2 months ago

[TASK] Change to named keys in EXT:seo when using generateMetaTags hook

For EXT:seo we now use named keys for the hooks we register for
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Frontend\Page\PageGenerator']['generateMetaTags']. This will make it easier to disable specific
generators.

Resolves: #89477
Releases: master, 9.5
Change-Id: I17e2ca78b484010010b775485e554133b11aaf4c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62042
Tested-by: TYPO3com <>
Tested-by: Chris Müller <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Chris Müller <>
Reviewed-by: Andreas Fernandez <>

Revision acd41a34 (diff)
Added by Richard Haeser about 2 months ago

[TASK] Change to named keys in EXT:seo when using generateMetaTags hook

For EXT:seo we now use named keys for the hooks we register for
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Frontend\Page\PageGenerator']['generateMetaTags']. This will make it easier to disable specific
generators.

Resolves: #89477
Releases: master, 9.5
Change-Id: I17e2ca78b484010010b775485e554133b11aaf4c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62057
Tested-by: TYPO3com <>
Tested-by: Richard Haeser <>
Reviewed-by: Richard Haeser <>

History

#1 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62042

#2 Updated by Gerrit Code Review about 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62057

#3 Updated by Richard Haeser about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF