Bug #89521

typolink in ATagParams modifies original URL

Added by Alexander Stehlik 7 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When you generate a link in the stdWrap config of ATagParams of a typolink, the original link is replaced with the one generated for the ATagParams.

An example:

page = PAGE

page.10 = TEXT
page.10.typolink.parameter = <some_id>

page.10.typolink.ATagParams.outerWrap = data-some-other-url="|" 
page.10.typolink.ATagParams.cObject = COA
page.10.typolink.ATagParams.cObject {
  10 = TEXT
  10.typolink.parameter = <some_other_id>
  10.typolink.returnLast = url
  stdWrap.htmlSpecialChars = 1
}

Expected output:

<a href="/some-id" data-some-other-url="/some-other-id">Some ID</a>

Current output:

<a href="/some-other-id" data-some-other-url="/some-other-id">Some ID</a>

Associated revisions

Revision ddd4310e (diff)
Added by Alexander Stehlik 7 months ago

[BUGFIX] Backup last typolink URL before processing ATagParams

This prevents typolinks called in the stdWrap of ATagParams
from modifying the original link URL.

Resolves: #89521
Releases: master, 9.5
Change-Id: Ief6d7c8a7345bab16b98d840e31807e5ab07763d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62126
Tested-by: TYPO3com <>
Tested-by: Oliver Bartsch <>
Tested-by: Susanne Moog <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Susanne Moog <>

Revision 0afcb393 (diff)
Added by Alexander Stehlik 7 months ago

[BUGFIX] Backup last typolink URL before processing ATagParams

This prevents typolinks called in the stdWrap of ATagParams
from modifying the original link URL.

Resolves: #89521
Releases: master, 9.5
Change-Id: Ief6d7c8a7345bab16b98d840e31807e5ab07763d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62070
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Reviewed-by: Susanne Moog <>

History

#1 Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62126

#2 Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62126

#3 Updated by Gerrit Code Review 7 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62126

#4 Updated by Gerrit Code Review 7 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62126

#5 Updated by Gerrit Code Review 7 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62126

#6 Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62070

#7 Updated by Alexander Stehlik 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF