Bug #89667
closedPHPDoc for SubmitViewHelper looks incorrect
100%
Description
Looking at the PHPDoc for the SumitViewHelper it looks like the second example is wrong:
Is:
/**
* Creates a submit button.
*
* Examples
* ========
*
* Defaults
* --------
*
* ::
*
* <f:form.submit value="Send Mail" />
*
* Output::
*
* <input type="submit" />
*
* Dummy content for template preview
* ----------------------------------
*
* ::
*
* <f:submit name="mySubmit" value="Send Mail"><button>dummy button</button></f:submit>
*
* Output::
*
* <input type="submit" name="mySubmit" value="Send Mail" />
*/
should be:
/**
* Creates a submit button.
*
* Examples
* ========
*
* Defaults
* --------
*
* ::
*
* <f:form.submit value="Send Mail" />
*
* Output::
*
* <input type="submit" />
*
* Dummy content for template preview
* ----------------------------------
*
* ::
*
* <f:form.submit name="mySubmit" value="Send Mail"><button>dummy button</button></f:form.submit>
*
* Output::
*
* <input type="submit" name="mySubmit" value="Send Mail" />
*/
When using the <f.submit> as the PHPDoc suggestion I get
#1407060572: Fluid parse error in template BackendModule_action_index_a5e062765b6dffa1d95af238639101a7b55c1b56, line 10 at character 6. Error: The ViewHelper "<f:submit>" could not be resolved. Based on your spelling, the system would load the class "TYPO3Fluid\Fluid\ViewHelpers\SubmitViewHelper", however this class does not exist. (error code 1407060572).
Updated by Gerrit Code Review about 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62315
Updated by Gerrit Code Review about 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62315
Updated by Tomas Norre Mikkelsen about 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset ae97e2d8240d2aa5788337c353492b07018455f9.
Updated by Gerrit Code Review about 5 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62278
Updated by Tomas Norre Mikkelsen about 5 years ago
- Status changed from Under Review to Resolved
Applied in changeset 5e7b8a042d2619e2cde9ad4a71d9846015d51947.