Project

General

Profile

Actions

Bug #89729

closed

Exception when adding LinkButtons to a SplitButton

Added by Johannes Kasberger about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2019-11-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The addItem method of the SplitButton class expects items of the type AbstractButton. In the render method it calls getName and getValue that are only defined for InputButtons but not LinkButtons resulting in an exception.

I don't see a reason why LinkButtons should not be supported for SplitButtons so I'd suggest that the fix is to add the rendering code for LinkButtons (or simply use the render method of the children).

Actions #1

Updated by Markus Klein about 5 years ago

  • TYPO3 Version changed from 10 to 8
Actions #2

Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62360

Actions #3

Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62979

Actions #4

Updated by Markus Klein almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF