Task #89754

Follow-Up: Introduce native pagination for lists

Added by Alexander Schnitzler 15 days ago. Updated 15 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
Alexander Schnitzler
Category:
-
Target version:
-
Start date:
2019-11-23
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

- Switch the order of constructor arguments $currentPageNumber
and $itemsPerPage of both the ArrayPaginator and QueryResultPaginator
classes as the $currentPageNumber needs to be set on every object
construction whereas the $itemsPerPage argument only needs to be
changed for paginators that use a differen amount of items per page
other than the default of 10.
- Change visibility of properties of both the ArrayPaginator and the
QueryResultPaginator from protected to private as both classes are
marked final.

Associated revisions

Revision cf90cfde (diff)
Added by Alexander Schnitzler 15 days ago

[TASK] Follow-up: Introduce native pagination for lists

- Switch the order of constructor arguments $currentPageNumber
and $itemsPerPage of both the ArrayPaginator and QueryResultPaginator
classes as the $currentPageNumber needs to be set on every object
construction whereas the $itemsPerPage argument only needs to be
changed for paginators that use a differen amount of items per page
other than the default of 10.
- Change visibility of properties of both the ArrayPaginator and the
QueryResultPaginator from protected to private as both classes are
marked final.

Releases: master
Resolves: #89754
Change-Id: If900c1b786aef7f155bbe0b06cdd167f59e8c9ff
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62418
Tested-by: TYPO3com <>
Tested-by: Daniel Goerz <>
Tested-by: Susanne Moog <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Susanne Moog <>

History

#1 Updated by Gerrit Code Review 15 days ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62418

#2 Updated by Anonymous 15 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF