Task #89754
Follow-Up: Introduce native pagination for lists
100%
Description
- Switch the order of constructor arguments $currentPageNumber
and $itemsPerPage of both the ArrayPaginator and QueryResultPaginator
classes as the $currentPageNumber needs to be set on every object
construction whereas the $itemsPerPage argument only needs to be
changed for paginators that use a differen amount of items per page
other than the default of 10.
- Change visibility of properties of both the ArrayPaginator and the
QueryResultPaginator from protected to private as both classes are
marked final.
Associated revisions
[TASK] Follow-up: Introduce native pagination for lists
- Switch the order of constructor arguments $currentPageNumber
and $itemsPerPage of both the ArrayPaginator and QueryResultPaginator
classes as the $currentPageNumber needs to be set on every object
construction whereas the $itemsPerPage argument only needs to be
changed for paginators that use a differen amount of items per page
other than the default of 10.
- Change visibility of properties of both the ArrayPaginator and the
QueryResultPaginator from protected to private as both classes are
marked final.
Releases: master
Resolves: #89754
Change-Id: If900c1b786aef7f155bbe0b06cdd167f59e8c9ff
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62418
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
History
#1
Updated by Gerrit Code Review 15 days ago
- Status changed from New to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62418
#2 Updated by Anonymous 15 days ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset cf90cfdeb513bffb6272047885f16aa950e83944.