Task #89766

Epic #83968: PSR-11 Initiative

Use ArrayObject for services instead of array for middleware services

Added by Benjamin Franzke over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
System/Bootstrap/Configuration
Start date:
2019-11-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Symfony 4.4 deprecated support for non-object services:
https://github.com/symfony/dependency-injection/commit/6f11b359ab9cc97838bc9fa7cf1480528bdcb54f

Symfony 5.0 introduced type declaration in Container->set which causes an exception when we set synthetic boolean services:
https://github.com/symfony/dependency-injection/blob/501d3378459fdc7993dc29b55c7d14fc27172768/Container.php#L144

Middlewares due not break (yet) as they are not set as synthetic service, but it is likely that they may break due to a type declaration that could be introduced in a 5.x release.

As array is no longer officially supported we should migrate to ArrayObject as preventative measure.

#1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62429

#2

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62429

#3

Updated by Benjamin Franzke over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF