Bug #89860
closedEmpty string as header in wizard items throws exception
100%
Description
When providing an empty string (for example because the label was not yet added to the locallang file) as header in a wizard item, opening the new content element wizard throws an exception.
This occurs because the method prepareContent()
in \TYPO3\CMS\Backend\Controller\ContentElement\NewContentElementController
uses if ($wInfo['header']) {
as condition instead of e.g. if (isset($wInfo['header'])) {
.
It's not a big issue, it just seems wrong because in the if block it specifically uses a fallback in case the header is empty, which currently will never be used because of the if condition.
Updated by Gerrit Code Review almost 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62540
Updated by Gerrit Code Review almost 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62540
Updated by Gerrit Code Review almost 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62540
Updated by Gerrit Code Review almost 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62460
Updated by Susanne Moog almost 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f1c1033fe6a7203655648eded13fbec16a7eac1f.