Bug #89861: EXT:core TypoScriptContstantsViewHelper uses ambiguous and future-conflicting method name - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #89861

closed

EXT:core TypoScriptContstantsViewHelper uses ambiguous and future-conflicting method name

Added by Claus Due almost 5 years ago. Updated almost 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Fluid

Target version:

Start date:

2019-12-05

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The TypoScriptConstantsViewHelper from EXT:core contains an ambiguous method, getName(), which returns a field name.

This method name will be reserved in Fluid 3.0 and should be avoided entirely - which is a good opportunity to give it a more appropriate name, e.g. getFieldName().

In addition, the same ViewHelper accesses deprecated properties $this->viewHelperVariableContainer which should be changed to $this->renderingContext->getViewHelperVariableContainer().

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62541

Actions

Copy link