Task #89866

Use new Typo3Copyright API everywhere

Added by Mathias Brodala 6 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-12-05
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

After #89756 there are still some locations which directly use e.g. the TYPO3_copyright_year constant and should be migrated to the Typo3Copyright class.

Related issues

Related to TYPO3 Core - Task #89756: Move Copyright information generation out of TYPO3 Backend Closed 2019-11-23

Associated revisions

Revision 39abe760 (diff)
Added by Benni Mack 5 months ago

[TASK] Move constant declaration to class constants

Using Class constants instead of constants that are defined during
runtime has the following benefits:

- Naming can be made more consistent (and separated)
- Speeding up requests where the constants are not needed
- Benefit from Opcaching of class loading instead of dynamic runtime definition
- Testing framework has less "bootstrap" to do

This affects the following constants:
- TYPO3_copyright_year
- TYPO3_URL_GENERAL
- TYPO3_URL_LICENSE
- TYPO3_URL_EXCEPTION
- TYPO3_URL_DONATE
- TYPO3_URL_WIKI_OPCODECACHE

The constants are now deprecated.

In addition, the "Typo3Copyright" class is now called "TYPO3Information".

Resolves: #89866
Releases: master
Change-Id: I607c90cb281179bda9875504d258daefd3471868
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62624
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Tested-by: Georg Ringer <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Mathias Brodala 6 months ago

  • Related to Task #89756: Move Copyright information generation out of TYPO3 Backend added

#2 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62624

#3 Updated by Gerrit Code Review 5 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62624

#4 Updated by Gerrit Code Review 5 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62624

#5 Updated by Benni Mack 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF