Project

General

Profile

Actions

Bug #90000

closed

Translation of content in gridelements fails

Added by Nikita Hovratov over 4 years ago. Updated over 4 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Localization
Target version:
-
Start date:
2019-12-20
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Adding a new content element to a already translated gridelement in the default language and then clicking the translate button causes an empty summary of content uids, which leads to an error at the finishing step.

How to reproduce:
- TYPO3 9 Site Setup with multiple languages.
- Install gridelements extension.
- Create a grid container.
- Click on translate and select translate or copy.
- Now create a new content element inside of the grid container in the default language.
- Click again on translate.
- The new content element is missing in step 3.
- The final step can not be finished and you need to exit with ESC.

Current workaround:
We could figure out that the problem is related to the special colPos value of the content in grid container: -1.
This value is ignored and the content element is not found.
Adding a pseudo-column in the backend-layout with the colPos -1 fixes the issue.

Furthermore we found the loop of the columnUids in Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Localization.ts

Line 180: columnList.forEach((colPos: number): void => {
...

All the content in the column -1 is ignored, because the value is not in the columnList.
Possible fix would be adding "-1" to the columnList.


Files

step3-missing-uid.png (33.1 KB) step3-missing-uid.png Nikita Hovratov, 2019-12-20 15:42
Actions #1

Updated by Jo Hasenau over 4 years ago

Actually the translate button is not supposed to synchronize inline children of translated elements.
That's why there is a localize/synchronize button within gridelements containers.

Anyway, while it would make sense to add -1 to the column list, this should not be the job of the core but of Gridelements.
If this is not possible to do that without a core change, we should still keep this ticket for a feature request, to get the option of adding columns to the loop of column IDs.

I will add this ticket to https://gitlab.com/coderscare/gridelements/issues/66 to keep track of it in Gridelements too.

Actions #2

Updated by Georg Ringer over 4 years ago

  • Status changed from New to Rejected

Closing it as it will be solved within gridelements. If core changes are required, feel free to open a new issue

Actions

Also available in: Atom PDF