Task #90011

Media renderer cleanup

Added by Mario Lubenka about 1 month ago. Updated about 1 month ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Start date:
2019-12-25
Due date:
% Done:

0%

TYPO3 Version:
10
PHP Version:
7.2
Tags:
renderer
Complexity:
easy
Sprint Focus:

Description

I ran into a use case where I have to override the HTML rendered by the Core media renderers (TYPO3\CMS\Core\Resource\Rendering).

A renderer usually consists of two parts: preparing the settings and rendering the tag.
In most renderers this is done in render() method. That means that someone who wants to change the rendered HTML tag has to also copy the options that are set inside the tag.

Additionally most of the code is quite similar.
Both YouTube- and Vimeo-Renderers only differ in the URL generated and the options being available.
The HTML5 Video- and Audio-Renderers only differ in the tag that is rendered and the attributes "width" and "height" being missing from audio.

History

#1 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62762

#2 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62762

Also available in: Atom PDF