Task #90011
closed
Media renderer cleanup
0%
Description
I ran into a use case where I have to override the HTML rendered by the Core media renderers (TYPO3\CMS\Core\Resource\Rendering).
A renderer usually consists of two parts: preparing the settings and rendering the tag.
In most renderers this is done in render() method. That means that someone who wants to change the rendered HTML tag has to also copy the options that are set inside the tag.
Additionally most of the code is quite similar.
Both YouTube- and Vimeo-Renderers only differ in the URL generated and the options being available.
The HTML5 Video- and Audio-Renderers only differ in the tag that is rendered and the attributes "width" and "height" being missing from audio.
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62762
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62762
Updated by Christian Kuhn over 1 year ago
- Status changed from Under Review to Closed
Hey. The patch has been abandoned long ago. I hope it's ok to close here for now. In case we still want to refactor this code, we should give it a fresh start with a new issue.