Task #90022

Refactor & streamline TypoLinkViewHelper implementations

Added by Oliver Hader 10 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2019-12-27
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
7.2
Tags:
Complexity:
Sprint Focus:

Description

  • avoid assigning and forwarding multiple variables
  • preparation for further enhancements
  • Uri UnitTest case mostly tested TypoLinkCodecService (it was a FunctionalTest) and to 1/3 a simple additionalParams case
  • Link UnitTest case mostly tested TypoLinkCodecService (it was a FunctionalTest)

Associated revisions

Revision d53b9bf7 (diff)
Added by Oliver Hader 10 months ago

[TASK] Refactor & streamline TypoLinkViewHelper implementations

  • avoid assigning and forwarding multiple variables
  • preparation for further enhancements of view helpers
  • Uri UnitTest case mostly tested TypoLinkCodecService
    (it was a FunctionalTest) and to 1/3 a simple additionalParams case
  • Link UnitTest case mostly tested TypoLinkCodecService
    (it was a FunctionalTest)

Resolves: #90022
Releases: master
Change-Id: If65e42d4ca8085855f3f335d1eb2604be9a36fe0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62775
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Georg Ringer <>
Reviewed-by: Benni Mack <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62775

#2 Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62775

#3 Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62775

#4 Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62775

#5 Updated by Oliver Hader 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF