Project

General

Profile

Actions

Task #90101

closed

Remove custom InvalidArgumentException from core

Added by Markus Klein about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Code Cleanup
Target version:
-
Start date:
2020-01-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:
On Location Sprint

Description

InvalidArgumentException is a PHP native exception inheriting from \LogicException.
Our custom one extends \RuntimeException

This is rather unexpected and conception-wise not clever.

Replace it with a simple pure RuntimeException.

Actions #1

Updated by Gerrit Code Review about 4 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62862

Actions #2

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62862

Actions #3

Updated by Markus Klein about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Markus Klein about 4 years ago

As decided within the product team it is okay to remove this rather new and internal exception with deprecation phase and further documentation.

Actions #5

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF