Project

General

Profile

Actions

Bug #90113

closed

Wrong explaination of addPlugin

Added by Stefan Froemken over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extension Manager
Target version:
-
Start date:
2020-01-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

Hallo Core Team,

in ExtensionManagerUtility at addPlugin you wrote:

@param array $itemArray Numerical array: [0] => Plugin label, [1] => Underscored extension key, [2] => Path to plugin icon...

Of cause array key 1 could be the extension key, but one extension can provide multiple plugins and in that case you need something to differ.
It's the value which will be stored in column CType (or list_type). It's more a plugin name or a content element identifier. Further you have the extensionName as third parameter already. So it does not make sense to define ExtKey twice.

Stefan

Actions #1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62921

Actions #2

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62934

Actions #3

Updated by Benni Mack over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF