Project

General

Profile

Actions

Bug #90164

closed

Page module: Buttons in tt_content_drawHeader() not shown if editor has no permissions to default language

Added by Christian Eßl almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Start date:
2020-01-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The following scenario:
  • A site with the languages "default" and "german"
  • The configured backend editor has edit permissions for the language "german", but not for "default".
  • Now open the page module as the editor
  • In the select box, switch from "Columns" mode to "Languages" mode.
  • The shown content elements for the "german" language will NOT show the usual buttons in their top bar (edit, show/hide, delete).
    If the editor has permissions for both "default" and "german", he can see the buttons for both languages.

The reason for this behaviour lies in the PageLayoutController.php. Here the property $this->EDIT_CONTENT is saved, which holds the value, if the editor should be allowed to edit a content element. The PageLayoutView later receives this value in its property $doEdit.
In "Languages" mode, you will always see both the default language and the language that is chosen in the second select. But if this mode is chosen, $this->EDIT_CONTENT will always use the default language for determining, if an editor should be allowed to edit content. But these permissions should be checked independently for each language.

Actions #1

Updated by Christian Eßl almost 5 years ago

  • TYPO3 Version changed from 10 to 9
Actions #2

Updated by Christian Eßl almost 5 years ago

  • TYPO3 Version changed from 9 to 10
Actions #3

Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63009

Actions #4

Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63117

Actions #5

Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63009

Actions #6

Updated by Christian Eßl almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF