Bug #90165
closedIncorrect comparison in indexed_search SearchController do not set configured languageUid
100%
Description
The indexed_search SearchController->initialize() function creates the wrong languageUid in search settings.
The condition
if ($searchData['languageUid'] ?? '' === 'current')
is true, if the $searchData['languageUid'] is set. The value of the $searchData['languageUid'] doesn't matter.
This is the case, because the
'' === 'current'
comparission is evaluated first, than the
$searchData['languageUid'] ?? false
operator.
The correct condition would be
if (($searchData['languageUid'] ?? '') === 'current')
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63628
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63589
Updated by Benni Mack over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f5d72d2cba397995ea157c21a1b93240092f0e8a.