Task #90204: Use a reference variable to pass $this into hooks - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #90204

closed

Use a reference variable to pass $this into hooks

Added by Alexander Schnitzler about 4 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Alexander Schnitzler

Category:

Code Cleanup

Target version:

Start date:

2020-01-25

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

no-brainer

Sprint Focus:

Description

Unfortunately phpstan looses the correct type of $this
as soon as $this is passed into a hooked as a hook method
parameter without a specific type. This leads to phpstan
losing the information about available methods and properties
of $this.

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63036

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63036

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63036

Actions

Copy link