Bug #90216: Internal Note does not display when user is invalid - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #90216

closed

Internal Note does not display when user is invalid

Added by Benjamin Serfhos almost 5 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Miscellaneous

Target version:

next-patchlevel

Start date:

2020-01-27

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

sys_note

Complexity:

easy

Is Regression:

Sprint Focus:

Description

Current state:
All internal notes with active creator are displayed. Internal Notes are hidden when the creator is inactive/deleted.

Desirable outcome:
When a note is not personal and the user is deactivated, the note should still be displayed.

--
During the removal of extbase from sys_note repository the query got adjusted a bit and this `feature` got introduced.
See:
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/55804/
- https://forge.typo3.org/issues/84055

Possible solution:
- Add restriction manually

Files

Download all files

sys_note_repository.patch (2.05 KB) sys_note_repository.patch	Manual handling	Benjamin Serfhos, 2020-01-27 15:15
90216.patch (2.36 KB) 90216.patch		Benjamin Serfhos, 2020-01-27 16:00

Actions

Copy link

Updated by Benjamin Serfhos almost 5 years ago

File 90216.patch 90216.patch added

Looks like my account is not able to push to gerrit anymore; I tried to push it but my public key is not accepted.
Added patch with commit message ¯\_(ツ)_/¯

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63246

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63246

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63226

Actions

Copy link

Updated by Nikita Hovratov almost 5 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset caef3da580c74ce50dd2d02f6776a405c6fe99c7.

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63226

Actions

Copy link