Project

General

Profile

Actions

Bug #90216

closed

Internal Note does not display when user is invalid

Added by Benjamin Serfhos about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
Start date:
2020-01-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
sys_note
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Current state:
All internal notes with active creator are displayed. Internal Notes are hidden when the creator is inactive/deleted.

Desirable outcome:
When a note is not personal and the user is deactivated, the note should still be displayed.

--
During the removal of extbase from sys_note repository the query got adjusted a bit and this `feature` got introduced.
See:
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/55804/
- https://forge.typo3.org/issues/84055

Possible solution:
- Add restriction manually


Files

sys_note_repository.patch (2.05 KB) sys_note_repository.patch Manual handling Benjamin Serfhos, 2020-01-27 15:15
90216.patch (2.36 KB) 90216.patch Benjamin Serfhos, 2020-01-27 16:00
Actions #1

Updated by Benjamin Serfhos about 4 years ago

Looks like my account is not able to push to gerrit anymore; I tried to push it but my public key is not accepted.
Added patch with commit message ¯\_(ツ)_/¯

Actions #2

Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63246

Actions #3

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63246

Actions #4

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63226

Actions #5

Updated by Nikita Hovratov about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Gerrit Code Review about 4 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63226

Actions #7

Updated by Nikita Hovratov about 4 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF