Bug #90216

Internal Note does not display when user is invalid

Added by Benjamin Serfhos 29 days ago. Updated 7 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
Start date:
2020-01-27
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
sys_note
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Current state:
All internal notes with active creator are displayed. Internal Notes are hidden when the creator is inactive/deleted.

Desirable outcome:
When a note is not personal and the user is deactivated, the note should still be displayed.

--
During the removal of extbase from sys_note repository the query got adjusted a bit and this `feature` got introduced.
See:
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/55804/
- https://forge.typo3.org/issues/84055

Possible solution:
- Add restriction manually

sys_note_repository.patch View - Manual handling (2.05 KB) Benjamin Serfhos, 2020-01-27 15:15

90216.patch View (2.36 KB) Benjamin Serfhos, 2020-01-27 16:00

Associated revisions

Revision caef3da5 (diff)
Added by Nikita Hovratov 10 days ago

[BUGFIX] Show sys_note of hidden or deleted author

Since the querybuilder is used to fetch notes the default restrictions
of both apply sys_note and be_users. This patch removes the default
restrictions and adds them manually only for sys_note. The names of
hidden or deleted authors are replaced with "unknown author" instead.

Fixes: #90216
Releases: master, 9.5
Change-Id: I7613909dad078256747e8b719bf68d64729fb56d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63246
Tested-by: Stefan Froemken <>
Tested-by: Georg Ringer <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Stefan Froemken <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Benni Mack <>

Revision 4ad70755 (diff)
Added by Nikita Hovratov 7 days ago

[BUGFIX] Show sys_note of hidden or deleted author

Since the querybuilder is used to fetch notes the default restrictions
of both apply sys_note and be_users. This patch removes the default
restrictions and adds them manually only for sys_note. The names of
hidden or deleted authors are replaced with "unknown author" instead.

Fixes: #90216
Releases: master, 9.5
Change-Id: I7613909dad078256747e8b719bf68d64729fb56d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63226
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Tested-by: Richard Haeser <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Richard Haeser <>

History

#1 Updated by Benjamin Serfhos 29 days ago

Looks like my account is not able to push to gerrit anymore; I tried to push it but my public key is not accepted.
Added patch with commit message ¯\_(ツ)_/¯

#2 Updated by Gerrit Code Review 10 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63246

#3 Updated by Gerrit Code Review 10 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63246

#4 Updated by Gerrit Code Review 10 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63226

#5 Updated by Nikita Hovratov 10 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review 7 days ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63226

#7 Updated by Nikita Hovratov 7 days ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF